wouterfennis / CodeRefactorFW

For ASP Assignment
0 stars 1 forks source link

Refactor het SWITCH statement #7

Closed wouterfennis closed 8 years ago

wouterfennis commented 8 years ago

In OverviewController.java zit een switch statement. Probeer te kijken of je hier nog optimalisatie uit kan halen.

    private JSONObject createLink(ArrayList<Result> myResults)
            throws JSONException {
        JSONObject link = new JSONObject();
        for (Result r : myResults) {
            switch (r.getMyAnswer().getAnswer_id()) {
            case 1:
                link.put("type", 1);
                break;
            case 2:
                link.put("type", 2);
                break;
            case 3:
                link.put("type", 3);
                break;
            case 4:
                link.put("type", 4);
                break;
            case 5:
                link.put("type", 5);
                break;
            case 6:
                link.put("type", 6);
                break;
            case 7:
                link.put("strength", 1);
                break;
            case 8:
                link.put("strength", 2);
                break;
            case 9:
                link.put("strength", 3);
                break;
            case 10:
                link.put("strength", 4);
                break;
            case 11:
                link.put("strength", 5);
                break;
            case 12:
                link.put("distance", 5);
                break;
            case 13:
                link.put("distance", 4);
                break;
            case 14:
                link.put("distance", 3);
                break;
            case 15:
                link.put("distance", 2);
                break;
            case 16:
                link.put("distance", 1);
                break;
            }
        }
        return link;
    }
joeryhuiden commented 8 years ago

Hier heb ik geen directe oplossing voor gevonden (helaas)