search

wouterhardeman / play2-maven-plugin

Automatically exported from code.google.com/p/play2-maven-plugin
0 stars 0 forks source link

Remove tricky mainLang autodetection mechanism #11

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Now, if <mainLang> configuration parameter is not set (to "java" or "scala") 
autodetection is performed.
Plugin looks for "play-java" artifact in plugin dependecies.

What I don't like:
- this artifact is different in Play! 2.1.x and 2.2.x - different "groupId"
- should I check only direct dependencies or transitive as well?
 a) direct only - "play-java" has to be added to project dependencies even if it's added transitively (by "play-jpa" for example)
 b) direct and transitive - in Play! 2.1.x "play-jdbc" artifact depends on "play-java"; if "scala" is desired mainLang, "play-java" should be added to "play-jdbc" dependency exclusions

There is no good solution. I will remove it completely. This will lead to 
removal of some "tricky" logic in the plugin.

Default value will be "scala". For ALL Java projects you will have to add:

<configuration>
    <mainLang>java</mainLang>
</configuration>

Original issue reported on code.google.com by gslowiko...@gmail.com on 22 Oct 2013 at 2:35

GoogleCodeExporter commented 8 years ago 
Fixed in http://code.google.com/p/play2-maven-plugin/source/detail?r=218

1.0.0-alpha4-SNAPSHOT version deployed.

Original comment by gslowiko...@gmail.com on 22 Oct 2013 at 2:46