wouterhardeman / play2-maven-plugin

Automatically exported from code.google.com/p/play2-maven-plugin
0 stars 0 forks source link

Make plugin compatible with Maven 2.x #49

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Maven 2.x does not support "${plugin}" expression. There is

    @Parameter( defaultValue = "${plugin}", readonly = true, required = true )
    private PluginDescriptor plugin;

in mojo parameters.

See 
http://maven.apache.org/ref/3.2.3/maven-core/apidocs/org/apache/maven/plugin/Plu
ginParameterExpressionEvaluator.html for details.

This has to be changed to:

    @Parameter( property = "plugin.groupId", readonly = true, required = true )
    private String pluginGroupId;

    @Parameter( property = "plugin.version", readonly = true, required = true )
    private String pluginVersion;

because "${plugin.*}" expressions are supported by old Maven versions.

Original issue reported on code.google.com by gslowiko...@gmail.com on 12 Oct 2014 at 9:11

GoogleCodeExporter commented 8 years ago
Implemented in https://code.google.com/p/play2-maven-plugin/source/detail?r=724.

Original comment by gslowiko...@gmail.com on 12 Oct 2014 at 9:14