search

woven-planet / l5kit

L5Kit - https://woven.toyota
https://woven-planet.github.io/l5kit
857 stars 278 forks source link

[Suggestion] Do NOT name the key of relative state_index as 'frame_index' in the return of AgentDataset #291

Closed dongb5 closed 3 years ago

dongb5 commented 3 years ago

It is very confused (at least for me) that whether it is the absolute index of frame or the relative index in a scene, because frame_index is used as the absolute index in some other functions, such as functions in data/filter.py.

lucabergamini commented 3 years ago

thanks for the suggestion. I don't have the bandwidth to rename this in the whole codebase right now, but maybe in the future I'll take a look into doing it