wovencode / OpenMMO

OpenMMO - Groundwork
http://open-mmo.net
Other
179 stars 30 forks source link

[network][Login Player] LoginPlayer DevExtension Hook invoked with a null reference. #64

Open francy51 opened 4 years ago

francy51 commented 4 years ago

possible typo in one devExtension Hook related to NetworkManager and LoginPlayer

wovencode commented 4 years ago

does this still happen?

any note in the log recently?

DX4D commented 3 years ago

The issue was in the hook invocation - the parameters were not being passed in by the Invoke method.

DX4D commented 3 years ago

Zombie Bug - But at least now we have a debug log: https://i.imgur.com/f9pQJhu.png

DX4D commented 3 years ago

Possible Theory: LoginPlayer may be called when the NetworkConnection is null while the client is between zones. Adding a Debug.Log to the login player method to validate the state of each param will help us diagnose the issue now and in the future. Eg: Account x logged in with Player y on Connection z <- (something along those lines)