search

wovo / hwlib

C++ OO micro-controller library for close-to-the-hardware programming
Boost Software License 1.0
57 stars 26 forks source link

Changed #include "sam3.h" to #include "sam3xa.h" #24

Closed JulianvDoorn closed 5 years ago

JulianvDoorn commented 5 years ago

Sam3.h is not provided with the *.atpack provided by http://packs.download.atmel.com/ instead it is something which can only be received via the headers provided/generated by Atmel Studio. (Not even asf provides it) Which I personally consider a slightly-less-than official resource.

Sam3xa.h instead is provided by the atpack, while sam3.h is only an alias towards sam3xa.h. Sam.h could be an alternative but I imagine conflicts occurring with other sam based devices, so the most specialized header would imo be the best fit.

JulianvDoorn commented 5 years ago

Other than that, using sam3.h breaks my projects that don't use bmptk or the Arduino framework. (And I do not intent copying source files from the Arduino repository, ew)

wovo commented 5 years ago

Funny, the file that is now changed is from Atmel :) and the files you could't find anywhere else are also from Atmel and with a permissive license... But who cares, if this works easier....

JulianvDoorn commented 5 years ago

The changes were approved however not merged, I take that as a mistake?

wovo commented 5 years ago

OK...

done now?

Wouter van Ooijen

0638150444 - HL15 4.060

From: Julian van Doorn notifications@github.com Sent: Wednesday, July 17, 2019 12:15 PM To: wovo/hwlib hwlib@noreply.github.com Cc: Wouter van Ooijen wouter.vanooijen@hu.nl; State change state_change@noreply.github.com Subject: Re: [wovo/hwlib] Changed #include "sam3.h" to #include "sam3xa.h" (#24)

The changes were approved however not merged, I take that as a mistake?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/wovo/hwlib/pull/24?email_source=notifications&email_token=ACE643DPPAOERAPBFFKFD3TP73WLRA5CNFSM4IEBUC32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DXI4Q#issuecomment-512193650, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACE643F4A3JOIOGOQW5S5F3P73WLRANCNFSM4IEBUC3Q.

JulianvDoorn commented 5 years ago

https://github.com/wovo/bmptk/pull/5

Noticed that bmptk does not directly include the folder containing sam3xa.h