search

wovo / hwlib

C++ OO micro-controller library for close-to-the-hardware programming
Boost Software License 1.0
58 stars 26 forks source link

GLCD clear() does not clear entire buffer / hangs processor #8

Closed cjsmeele closed 6 years ago

cjsmeele commented 6 years ago

504 is out of range for uint8_t: https://github.com/wovo/hwlib/blob/98d3aaa81079aebfc93532a8d0c13d36fd19ae43/library/hwlib-glcd-5510.hpp#L141

FWIW: -Wtype-limits detects this, also via -Wextra.

wovo commented 6 years ago

thanks, has been corrected.

Wouter van Ooijen

0638150444 - DL200 2.86

Van: Chris Smeele notifications@github.com Verzonden: maandag 2 oktober 2017 13:27 Aan: wovo/hwlib CC: Subscribed Onderwerp: [wovo/hwlib] GLCD clear() does not clear entire buffer / hangs processor (#8)

504 is out of range for uint8_t: https://github.com/wovo/hwlib/blob/98d3aaa81079aebfc93532a8d0c13d36fd19ae43/library/hwlib-glcd-5510.hpp#L141

FWIW: -Wtype-limits detects this, also via -Wextra.

- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/wovo/hwlib/issues/8, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AInubI6IGvxsqVzZGFBdpHBSRFzy-Yooks5soMiEgaJpZM4Pqglv.

Bob-Thomas commented 6 years ago

If it's resolved this issue should probably be closed :3