wow-actions / welcome

💖 Welcomes new users by creating a comment in their first time issue/PR
MIT License
8 stars 4 forks source link

build: upgrade to node20 #12

Open lampajr opened 6 months ago

lampajr commented 6 months ago

Hi team :wave:, We are using this action as part of some of our projects and we started noticing the warning below, that's why I created this PR.

Description

Upgrade the node versio that will be used by the action at runtime.

Motivation and Context

GitHub started warning actions running on node16: image

[run](https://github.com/Hyperfoil/Horreum/actions/runs/8214138182/job/22466298403)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: wow-actions/welcome@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Types of changes

Self Check before Merge

lampajr commented 5 months ago

Hey @bubkoo, sorry to bother you and I hope you are the right person to tag here! Is there any chance to get this in?

Piedone commented 5 months ago

I just bumped into this. This action is really the best for this task (and much better than the official actions/first-interaction), so it would be great to have this fixed. It seems like a very simple fix, the action just works with Node 20 too. I forked this repo for Orchard Core too, for this: https://github.com/OrchardCMS/OrchardCore/pull/15708.