The “Mary Sue Protocol” (“MSP” for short) is a simple challenge/response protocol for RP UI add-ons within WoW to communicate with each other and publish text information to other clients (such as RP character names and descriptions).
Creative Commons Zero v1.0 Universal
2
stars
1
forks
source link
Recursive Process call is missing isSafe parameter #21
No idea what this bug could manifest itself in, but it's pretty clearly incorrect.
A commit some time ago added a third parameter (isSafe) to the Process function. This is called recursively in the final elseif clause with some mumbo-jumbo about clearing fields that haven't been updated in some probe frequency.
Problem is that call never had the isSafe parameter added, so it's basically a no-op. The action will always be an empty string, and the block won't be entered because isSafe is never true on the recursive call.
No idea what this bug could manifest itself in, but it's pretty clearly incorrect.
A commit some time ago added a third parameter (
isSafe) to the Process function. This is called recursively in the final elseif clause with some mumbo-jumbo about clearing fields that haven't been updated in some probe frequency.Problem is that call never had the
isSafeparameter added, so it's basically a no-op. The action will always be an empty string, and the block won't be entered becauseisSafeis never true on the recursive call.