search

wow2006 / cudpp

Automatically exported from code.google.com/p/cudpp
Other
0 stars 0 forks source link

Code review request #47

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:

Add tridiagonal solvers to cudpp.

When reviewing my code changes, please focus on:

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by zhangyao...@gmail.com on 13 Feb 2010 at 12:34

GoogleCodeExporter commented 9 years ago 
Adding others to CC so they can help with the review if they have time.

Original comment by harr...@gmail.com on 13 Feb 2010 at 1:31

GoogleCodeExporter commented 9 years ago 
This is mostly done, but will close it once Yao finishes the changes we 
recommended.

Original comment by harr...@gmail.com on 22 Jul 2011 at 7:01

GoogleCodeExporter commented 9 years ago 
Should there be a check during the tridiagonal plan creation whether 
systemSize*sizeof(T) > shared memory size and return an error?

Original comment by AalDavid...@gmail.com on 22 Jul 2011 at 6:15

GoogleCodeExporter commented 9 years ago 
I addressed all of my own comments from my last review with r247, and Andrew 
Davidson's comment about configuration checking (in validateOptions in 
cudppPlan.cpp -- checks a few other things too).  Closing this.

Original comment by harr...@gmail.com on 28 Jul 2011 at 4:43