search

wowdev / WoWDBDefs

Client database definitions for World of Warcraft
Other
246 stars 95 forks source link

Define unknown lightning db2 fields #102

Closed Razinao closed 2 years ago

Razinao commented 2 years ago

Current unknown fields in lightning.dbd result in increased duration between two lightning strikes on 8.3.0

amended data points

Video proof of above edit: https://www.youtube.com/watch?v=A6-AB7awsqE

Marlamin commented 2 years ago

Seeing you named these you can also remove the two (now orphaned) column names from the column definitions on the top of the file.

Looks good otherwise though, bonus points for the video. :D

Razinao commented 2 years ago

Seeing you named these you can also remove the two (now orphaned) column names from the column definitions on the top of the file.

Looks good otherwise though, bonus points for the video. :D

Is there a preferred position for the renamed ones in the column definitions?

NVM, Alphabetical order, got it.

Marlamin commented 2 years ago

Oh, I thought you renamed them to existing fields. In that case, just rename

Field_1_13_2_30073_020Min -> MinIntervalTime Field_1_13_2_30073_021Max -> MaxIntervalTime

in column definitions as well.

Marlamin commented 2 years ago

Perfect, thanks!