pre-commit config, with whitespace fixes applied

wowdev / WoWDBDefs

Client database definitions for World of Warcraft

Other

246 stars 95 forks source link

pre-commit config, with whitespace fixes applied #110

Closed ferronn-dev closed 2 years ago

ferronn-dev commented 2 years ago

introduce pre-commit
end-of-file-fixer
trailing whitespace

Marlamin commented 2 years ago

For the DBDs please check if rewriting them with the verifier doesn't add any empty lines back or anything

ferronn-dev commented 2 years ago

Well you were right, it added empty lines back for empty DBDs. I'm not sure why those are around at all but they are. Disabled the end-of-file-fixer until that quirk is resolved.

Marlamin commented 2 years ago

There's an intentional newline between COLUMN and BUILD definitions so it's likely just that one, but we should probably just keep that around for parsers that have come to rely on it for some reason. Probably not worth going through the effort of fixing and possibly breaking something along the line. Rest looks fine, merging, thanks.