search

wowdev / WoWDBDefs

Client database definitions for World of Warcraft
Other
246 stars 95 forks source link

getexe.lua #127

Closed ferronn-dev closed 1 year ago

Marlamin commented 1 year ago

If this is for something automated like a GitHub action for updating definitions I would suggest against using a product => executable map as some products (namely wowz, wowlivetest and whatever I'm not thinking of) sometimes switch between live, PTR or beta executables.

This is the list WoW.tools currently uses:

$targets = [
        // Mainline
        "Wow.exe", "WowT.exe", "WowB.exe", 
        // Classic
        "WowClassic.exe", "WowClassicT.exe", "WowClassicB.exe", 
        // Old 64-bit specific builds
        "Wow-64.exe", "WowT-64.exe", "WowB-64.exe"    
    ];

It loops over install entries and extracts the first one it finds from that list.

ferronn-dev commented 1 year ago

Good idea. Done.

Marlamin commented 1 year ago

Planning on putting the rest of the action/whatever in this PR too?

ferronn-dev commented 1 year ago

At this point no; I'm just trying to get a baseline before building any more complicated infrastructure.

ferronn-dev commented 1 year ago

This lets me actually run the DBDefsDumper from within the devcontainer, which I couldn't do before.