search

wowdev / WoWDBDefs

Client database definitions for World of Warcraft
Other
254 stars 95 forks source link

6.0.1 - meta padding fixes #16

Closed barncastle closed 6 years ago

barncastle commented 6 years ago

Tested against a parser, everything works now except CriteriaTree, my version has a WDBC signature but a WDB2 header - help!

Also ItemModifiedAppearance.dbd had an additional column compared to my version - can someone confirm the structure.

Marlamin commented 6 years ago

Dangit. I'll have to see if my extract is correct.

On Mon, 19 Mar 2018, 13:26 barncastle, notifications@github.com wrote:

@barncastle commented on this pull request.

In definitions/GarrPlotUICategory.dbd https://github.com/wowdev/WoWDBDefs/pull/16#discussion_r175416769:

locstring categoryName_lang uint field_2890979807? int ID uint plotType

BUILD 6.0.1.18179 -field_329935761<32> +$noninline,id$ID<32>

For the record, this isn't noninline, previous build issue again.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wowdev/WoWDBDefs/pull/16#discussion_r175416769, or mute the thread https://github.com/notifications/unsubscribe-auth/AADEJIKAqDtGQkF1GhXBLsjQmwFeePW1ks5tf6QHgaJpZM4Svacf .

Marlamin commented 6 years ago

Looks like (in theory) my extract might be correct. 12GB zip of DBCs going from 6.0.1.18125 to 7.3.x here. Please double check if so, though. 8.0 isn't included as this is a pre-8.0 extract.

barncastle commented 6 years ago

@Marlamin I think this is my issue opposed to yours. Thanks for the dump though - I'll rerun the MD5 and row compare over the next couple of days with these.

Might be worth ditching this PR and starting afresh.

bloerwald commented 6 years ago

On “unverified ID columns”: either all ? or none. I don’t care which way around.

barncastle commented 6 years ago