search

wowdev / WoWDBDefs

Client database definitions for World of Warcraft
Other
254 stars 95 forks source link

todo - trailing underscores #17

Closed barncastle closed 6 years ago

barncastle commented 6 years ago

Fields in the following have trailing underscores

Marlamin commented 6 years ago

Are those from official names? Eww.

barncastle commented 6 years ago

I was dubious but apparently so - just checked renderservice... Personal preference is to burn them with fire but thats up for debate!

Marlamin commented 6 years ago

+1 🔥

bloerwald commented 6 years ago

Iirc those are fields that are union’d to a real type, C2Vector and md5digest.

Since we don’t do that, i think I’m fine with just removing the character and keeping it as verified.

Then again, I don’t see this as a big issue actually needing a change either.

Marlamin commented 6 years ago

Am fine with fixing these for purely aesthetic reasons.