search

wowdev / WoWDBDefs

Client database definitions for World of Warcraft
Other
254 stars 95 forks source link

SoundBus.dbd #38

Closed funjoker closed 6 years ago

funjoker commented 6 years ago

LAYOUT 7CC84C2D contains twice DefaultPlaybackLimit

LAYOUT 7CC84C2D
BUILD 8.0.1.26788, 8.0.1.26806, 8.0.1.26812, 8.0.1.26838, 8.0.1.26871, 8.0.1.26877, 8.0.1.26892, 8.0.1.26903, 8.0.1.26918, 8.0.1.26926, 8.0.1.26936, 8.0.1.26949, 8.0.1.26970, 8.0.1.26999, 8.0.1.27004, 8.0.1.27009, 8.0.1.27026, 8.0.1.27075, 8.0.1.27101, 8.0.1.27144, 8.0.1.27165, 8.0.1.27178, 8.0.1.27219, 8.0.1.27291, 8.0.1.27326, 8.0.1.27353, 8.0.1.27355, 8.0.1.27356, 8.0.1.27366, 8.0.1.27377, 8.0.1.27404, 8.0.1.27481, 8.0.1.27547, 8.0.1.27602, 8.0.1.27791, 8.0.1.27843, 8.1.0.27826, 8.1.0.27934
$id$ID<32>
DefaultPriority<u8>
DefaultPriorityPenalty<u8>
DefaultPlaybackLimit<u8>
DefaultVolume
DefaultPlaybackLimit<u8>
BusEnumID<8>
$noninline,relation$Parent<u16>

Fixed:

LAYOUT 7CC84C2D
BUILD 8.0.1.26788, 8.0.1.26806, 8.0.1.26812, 8.0.1.26838, 8.0.1.26871, 8.0.1.26877, 8.0.1.26892, 8.0.1.26903, 8.0.1.26918, 8.0.1.26926, 8.0.1.26936, 8.0.1.26949, 8.0.1.26970, 8.0.1.26999, 8.0.1.27004, 8.0.1.27009, 8.0.1.27026, 8.0.1.27075, 8.0.1.27101, 8.0.1.27144, 8.0.1.27165, 8.0.1.27178, 8.0.1.27219, 8.0.1.27291, 8.0.1.27326, 8.0.1.27353, 8.0.1.27355, 8.0.1.27356, 8.0.1.27366, 8.0.1.27377, 8.0.1.27404, 8.0.1.27481, 8.0.1.27547, 8.0.1.27602, 8.0.1.27791, 8.0.1.27843, 8.1.0.27826, 8.1.0.27934
$id$ID<32>
Flags<8>
DefaultPriority<u8>
DefaultPriorityPenalty<u8>
DefaultVolume
DefaultPlaybackLimit<u8>
BusEnumID<8>
$noninline,relation$Parent<u16>

Unsure if Flagsis signed or unsigned

Marlamin commented 6 years ago

I should also update verifier to catch issues like this. Currently don't have access to raw 8.1 exports to double check the change, will likely do so later this week.

Marlamin commented 6 years ago

Actually, PC was still on so was able to remote in.

From 8.1 with official names:

LAYOUT 7CC84C2D
BUILD 8.1.0.27826
$id$ID<32>
Flags<u8>
DefaultPriority<u8>
DefaultPriorityPenalty<u8>
DefaultVolume
DefaultPlaybackLimit<u8>
BusEnumID<8>
$noninline,relation$Parent<u16>
bloerwald commented 6 years ago

Bad commit is da2e3116404c20de8dd751647f665a10e8dcf752 which adds a second reference to DefaultPlaybackLimit. It was a manual merge for 8.1.0, so well, yeah. We should probably review the entire commit.

bloerwald commented 6 years ago

That specific dbd was fixed, but likely there is more broken stuff. In fact, it wasn't the broken commit but a previous BAD manual mapping. As indicated by the Flags field completely missing and the first DefaultPlaybackLimit being removed, not the one added in the commit. Fuck manual work..