search

wowdev / WoWDBDefs

Client database definitions for World of Warcraft
Other
246 stars 95 forks source link

Updated a bunch of 2.5.1 structs #78

Closed Ghaster closed 3 years ago

Ghaster commented 3 years ago

Based on 1.13.7 and patterns (e.g. many QuestID fields have been changed to 32 bit from 16 bit)

bloerwald commented 3 years ago

@Marlamin @barncastle do we want to merge layouts like suggested or do we want to be overly careful and maintain separate definitions?

Marlamin commented 3 years ago

It still scares me to merge them after the discussion we had recently :(

On Sun, Apr 4, 2021, 20:20 Bernd Lörwald @.***> wrote:

@Marlamin https://github.com/Marlamin @barncastle https://github.com/barncastle do we want to merge layouts like suggested or do we want to be overly careful and maintain separate definitions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wowdev/WoWDBDefs/pull/78#issuecomment-813077415, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMIJHOOUIA4CRM55ISSKLTHCUV5ANCNFSM42KF2P5Q .

bloerwald commented 3 years ago

De-deduplicated them, @Marlamin.

Thanks for the mappings, @Ghaster!