search

wowdev / WoWDBDefs

Client database definitions for World of Warcraft
Other
254 stars 95 forks source link

Update ChrRaces with official names #95

Closed funjoker closed 3 years ago

Marlamin commented 3 years ago

Did you verify if this is the right way around? Expected the S in RS to mean short and the L in RL to mean lore but in version definitions these are switched around now.

Marlamin commented 3 years ago

Not saying it's wrong btw, just not sure. Here's an excerpt from the mobile app to verify:

Lore_name       Short_name
Human           Human
Orc             Orc
Dwarf           Dwarf
Kaldorei        Elf
Forsaken        Undead
Shu'halo        Tauren
Gnome           Gnome
Darkspear       Troll
Bilgewater      Goblin
Sin'dorei       Elf
Draenei         Draenei
funjoker commented 3 years ago

Short is all trolls are named troll. Lore for trolls are darkspear or zandalari. Same for void elves, panderen etc.

Marlamin commented 3 years ago

Okay, sounds good!

bloerwald commented 3 years ago

Expected the S in RS to mean short and the L in RL to mean lor

Yeah, my reversing was reversed. You can see the code in that other issue

Marlamin commented 3 years ago

Expected the S in RS to mean short and the L in RL to mean lor

Yeah, my reversing was reversed. You can see the code in that other issue

bernd ur fired (and rehired please dont leave)