search

wowmaking / react-native-iron-source

Iron Source SDK React Native bridge
30 stars 37 forks source link

ADD METHOD isRewardedVideoPlacementCapped #61

Open ItagibaALIX opened 4 years ago

Kubessandra commented 4 years ago

I think a little update in the readme and this will be good

fearmear commented 4 years ago

Looks great. I going to test it before merging.

Thank you for your contribution!

Kubessandra commented 4 years ago

@fearmear Hello, I added a MIT License but this is the name of Redpill can you provide a MIT LICENSE with your name? or with wowmaking, we don't want to become the Owner of this project this is why I'm asking you to change the name in the License, the project need a License or this is illegal to use it.

https://opensource.stackexchange.com/questions/1720/what-can-i-assume-if-a-publicly-published-project-has-no-license

fearmear commented 4 years ago

Let's leave it as it was provided by the original creator. Please remove the license file from your PR.

Kubessandra commented 4 years ago

@fearmear If we let this like that this is illegal to use it.. this is maybe why so many people are not using the package, I will ask the author of the original package

fearmear commented 4 years ago

I don't think they will ever reply. I suggest we ignore the license issue. Obviously they intended to make it MIT that's why package.json has this.