search

wowmaking / react-native-iron-source

Iron Source SDK React Native bridge
30 stars 37 forks source link

[iOS] Fix manual framework install + standard IronSource CocoaPods install #7

Closed rawrmaan closed 5 years ago

rawrmaan commented 5 years ago

This fixes build errors that occur in the following scenarios:

  1. A user integrates IronSource.framework manually, in ~/Documents/IronSourceSDK or ios/Frameworks (newly supported in this PR)
  2. A user integrates IronSource via CocoaPods by following the regular CocoaPods instructions in IronSource's docs

Also fixes the header search path for finding RCTUtils.h. It was broken when this package was published as scoped under @wowmaking/react-native-iron-source, as npm structures the directory in node_modules one level deeper.

All changes are backward compatible.

Fixes #3.

StanislavMayorov commented 5 years ago

Thank you for your contribution!

rawrmaan commented 5 years ago

You're welcome! More on the way. Had to force-push just now because I accidentally added more commits to this PR's branch. Will open another PR for those changes.