search

wowmaking / react-native-iron-source

Iron Source SDK React Native bridge
30 stars 37 forks source link

Postinstall script breaks CI (and possibly non-Mac environments) #78

Open aurelienshz opened 3 years ago

aurelienshz commented 3 years ago

Hi,

The linkSKAdNetwork.sh post-install script is breaking yarn install on our (linux-based) CI environment, and would probably also break on a Linux development environment (I don't have one available to test, but I don't think there is a Linux version of the plutil command).

I'm thinking the script could be updated with the following logic:

  1. Test whether the plutil command is available using which
  2. If the command is not available, output a message telling the user that the SKAdNetwork could not be autolinked and that they have to manually check that the property is present in their info.plist
  3. If the command is available, keep going with the current implementation

Would you accept a PR implementing this logic?

Thanks a lot!

ghost commented 3 years ago

+1

I can confirm that the issue is reproducible on Linux environment as well

kyo504 commented 3 years ago

This issue is caused by this commit. plutil is not available on linux environment.

AllanKlaus commented 2 years ago

Is there any workaround to install it on linux?