search

wowserhq / blizzardry

JavaScript library for mastering the wizardry that is Blizzard's game files
MIT License
55 stars 15 forks source link

Use @wowserhq/eslint-config #104

Closed timkurvers closed 6 years ago

timkurvers commented 6 years ago

This PR uses the newly released wowserhq/eslint-config and updates the codebase accordingly.

Let's see whether Travis agrees this lints neatly.

timkurvers commented 6 years ago

Doesn't look like we have linting on Travis set up actually.

timkurvers commented 6 years ago

Had to add -DBUILD_SHARED_LIBS=ON to StormLib's CMake flags to ensure we end up with an .so on Linux so that ffi can find the library.

timkurvers commented 6 years ago

I think StormLib may have changed something in its CMake settings no longer defaulting to building as a shared library, which is why this change is required. In the future we may want to consider locking to a specific version of StormLib, not master.