wowserhq / blizzardry

JavaScript library for mastering the wizardry that is Blizzard's game files
MIT License
54 stars 15 forks source link

Fix Wrath of the Lich King DBC definitions #106

Closed timkurvers closed 6 years ago

timkurvers commented 6 years ago

Turns out some of the DBC definitions were not targeting 3.3.5a files but rather older versions.

This PR updates those definitions.

Let's wait for #104 before updating the base branch (it's currently set to upgrade/eslint-config) and merging this in.

fallenoak commented 6 years ago

Were all the other definitions fine? Not quite sure how to verify beyond spot checking the parsed output from each one.

timkurvers commented 6 years ago

I checked by going through all definitions and making sure that the data stream was fully exhausted, which was not the case for the ones included in this PR.