search

wowserhq / blizzardry

JavaScript library for mastering the wizardry that is Blizzard's game files
MIT License
54 stars 15 forks source link

BLP to PNG artifacts #82

Open DDuarte opened 8 years ago

DDuarte commented 8 years ago

Some .blp when converted to .png get artifacts:

tileset-duskwood-duskwoodcobblestone blp

This does not happen to all the BLPs. I couldn't figure out yet why it happens to some of them only.

Converting the BLPs with the BLPConverter.exe that was compiled with libblp.dll produces corrects PNGs:

tileset-duskwood-duskwoodcobblestone

This only seems to occur on Windows.

timkurvers commented 8 years ago

Ah, thanks!

Does this occur even when not using clustering? Run npm run reset, then configure the amount of workers to be 1 and run the pipeline server again.

I'm assuming the artifacts are consistent and always in the same place?

timkurvers commented 8 years ago

Worth mentioning that this might be an issue with how Wowser handles BLPs in its pipeline, instead.

DDuarte commented 8 years ago

These artifacts happened before clustering was added and they do seem to be always in the same spot but I have to confirm this.

This how BLPConverter processes the files, it uses FreeImage: https://github.com/Kanma/BLPConverter/blob/master/main.cpp#L161-L190

timkurvers commented 8 years ago

Thanks! I'm installing Visual Studio right now, might take a while.