Extract realm build info when provided

wowserhq / wowser

World of Warcraft in the browser using JavaScript and WebGL

MIT License

246 stars 63 forks source link

Extract realm build info when provided #120

Closed timkurvers closed 8 years ago

timkurvers commented 8 years ago

Not extracting this information will cause additional realms to be decoded incorrectly, potentially crashing and breaking the realm list in its entirety.

Works for a TrinityCore server, haven't tested this against ArcEmu yet.

timkurvers commented 8 years ago

Relevant implementation in TrinityCore: https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/authserver/Server/AuthSession.cpp#L934-L940

fallenoak commented 8 years ago

Looks good! Set up two realms, both populate in the realm selection, and when either one is chosen, a connection on the correct port is attempted.

fallenoak commented 8 years ago

Merged! 🎉