wowserhq / wowser

World of Warcraft in the browser using JavaScript and WebGL
MIT License
240 stars 63 forks source link

Feature: M2 texture animations #128

Closed fallenoak closed 8 years ago

fallenoak commented 8 years ago

At long last: support for UV, transparency, and vertex color animations in M2Material.

Witness waterfalls, lavafalls, sandfalls, and more come to life before your very eyes.

This depends on PRs #126 and #127. This should close #96, #97, and #98.

Please note that UV animations currently only cover translations. I haven't yet found any models with UV animations for rotation or scaling.

timkurvers commented 8 years ago

Tested this, looks fantastic! :+1: Let's settle #127 first, then we can merge this one.

fallenoak commented 8 years ago

I'm now creating far fewer event subscriptions for texture animations. Next up: removing the event handlers when disposing of the material.

fallenoak commented 8 years ago

Should be good to go, now! Let me know if there's anything else you think we should fix prior to merge.

fallenoak commented 8 years ago

Anything else we should change before merging this?

fallenoak commented 8 years ago

Fixed the mixed spaces and tabs!

@timkurvers Think it's ready now?

timkurvers commented 8 years ago

Yes! 🎉

fallenoak commented 8 years ago

Woo hoo!