wowserhq / wowser

World of Warcraft in the browser using JavaScript and WebGL

MIT License

240 stars 63 forks source link

fixed multiple realms selection #130

Closed Yehonal closed 8 years ago

Yehonal commented 8 years ago

and changed OS to pass warden check

timkurvers commented 8 years ago

Let's merge #120 first, as that contains the fix for allowing multiple realms to be handled correctly. It seems to be included in here, but it's difficult to see what's new.

After that we can have a look at the Win vs OSX identifier, as well as Trinity requiring a realm ID to be passed in.

Yehonal commented 8 years ago

i've splitted commit and changed that minor code-style

Yehonal commented 8 years ago

could you accept this PR? it is fully working and made long time ago

timkurvers commented 8 years ago

120 was merged, which contained the original fix for supporting multiple realms.

Could you rebase this on top of current master only including the TrinityCore fixes?

Yehonal commented 8 years ago

Splitted in:

https://github.com/wowserhq/wowser/pull/165

https://github.com/wowserhq/wowser/pull/166

timkurvers commented 8 years ago

Thanks 👍