search

wowserhq / wowser

World of Warcraft in the browser using JavaScript and WebGL
MIT License
246 stars 63 forks source link

Node 5, Babel 6 and npm 3 #63

Closed timkurvers closed 8 years ago

timkurvers commented 9 years ago

Investigate whether these cause any problems for Wowser.

petersandor commented 9 years ago

I have Node 5 & npm 3 (Win7 x64), so I tried it and everything seems to work.

I had to manually compile ffi bindings and install some module dependencies manually as well (was getting require errors all over the place).

I don't fully understand the consequences of moving from previous to this new flat module system.

Also there are a couple of Riot related JS errors, but the whole pipeline is working without any issues. How cool is that :smiley:

timkurvers commented 9 years ago

Excellent, thanks for checking! :+1:

Will give this a go later this week. Am planning on swapping out Riot with React.

timkurvers commented 9 years ago

Seem to run into https://github.com/node-ffi/node-ffi/issues/259 immediately on Node v5. Perhaps that doesn't apply to Windows?

Adding support for Node v4.x at the very least, seeing as it's long-term support.

timkurvers commented 8 years ago

Node 5.1.0 was just released and supposedly includes a fix!

timkurvers commented 8 years ago

Node 5.1 and npm3 confirmed working. :+1: Let's wait with Babel 6 until it's a bit more stable.