search

wowserhq / wowser

World of Warcraft in the browser using JavaScript and WebGL
MIT License
240 stars 63 forks source link

Bundling fails on fresh install with Node 5.3.0 and npm 3.3.12 #73

Open fallenoak opened 8 years ago

fallenoak commented 8 years ago

After starting up webpack using npm run web-dev, I get several errors from eslint, and one error related to iconv-lite. It appears that some or all of these errors prevent webpack from serving bundled assets.

Node version: 5.3.0 npm version: 3.3.12 wowser commit: db0fe2d

Output showing errors is here: https://gist.github.com/fallenoak/47e56634cda0e494eed6

Per timkurvers on gitter:

ah that could be npm 3 related actually

timkurvers commented 8 years ago

Thanks for reporting! Those errors definitely need to be looked at. I believe the iconv-lite issues would be solved by adding json-loader so that webpack can load JSON files.

I successfully reproduced this on my machine, but once webpack: bundle is now VALID. comes up, it's available on localhost:8080. That's not the case for you?

fallenoak commented 8 years ago

In general, it appears that any eslint rules that produce error messages in the console prevent the webpack bundle from appearing on screen. Instead, I get a page in my browser that reflects the same error messages from the console. I've been systematically setting eslintrc entries to disable rules to prevent this from being an issue.

fallenoak commented 8 years ago

It looks like I may have been wrong when I said it doesn't come up at all on localhost:8080 -- When there are eslint errors, the bundle still loads if I visit the root URL /, but if I visit /webpack-dev-server, the page shows the eslint errors and nothing else is displayed.

That said, the bundle that's rendered at / when there are eslint errors does not reload on changes like I'd expect. That might be because only /webpack-dev-server opens the appropriate websocket to listen for changes, though?

timkurvers commented 8 years ago

Ah I wasn't even aware the webpack-dev-server automatically reloads under /webpack-dev-server. I've been manually refreshing! :smile:

Getting rid of the linting 'errors' is probably the right way to go. :+1:

timkurvers commented 8 years ago

The iconv-lite issue is covered by b2b20cd9f775686f56b477819401057cc1f18510.

petersandor commented 8 years ago

Shall we silence the linter also? I have the changes ready for a PR :smile: including a small fix for reset task (was throwing some async/sync related warning).

timkurvers commented 8 years ago

Sorry @petersandor, I didn't see this comment until now and fixed up the npm run reset task directly on master. As for the linting errors, feel free to open a PR and we can discuss it there :+1: