search

wowserhq / wowser

World of Warcraft in the browser using JavaScript and WebGL
MIT License
246 stars 63 forks source link

Map namespacing #84

Closed fallenoak closed 8 years ago

fallenoak commented 8 years ago

Recent versions of JS have added a Map() type to the global namespace. Unfortunately, since the Wowser map class is also named Map(), it's not possible to reference JS's Map() without using the rather kludgy workaround of window.Map()

Seeing as WorldHandler() is called WorldHandler(), could we change the Wowser map class to be WorldMap() ?

timkurvers commented 8 years ago

Yep, great idea! :+1:

timkurvers commented 8 years ago

Covered by 680c7ab31f575bcf6de739fd19e62335676cb6f7.

fallenoak commented 8 years ago

Awesome! :+1: