search

wowsiddanth / pe

0 stars 0 forks source link

Unclear activity diagram #11

Open wowsiddanth opened 2 years ago

wowsiddanth commented 2 years ago

Steps to reproduce: Implementation -> Adding Date/Time to Tasks

This is a violation of UML, and thus, a Low severity.


Expected: Diamond present or paths merge into one when the alt paths remerge.


Actual: Horizontal line, which looks like a join node which is used for parallel paths, and thus inappropriate.


Screenshots:

image.png

nus-pe-script commented 2 years ago

Team's Response

image.png

As stated in CS2103T website, omitting merge node (diamond) is an acceptable simplification. It also does not cause ambiguities as a join node should have a fork node complementing it and both lines should be bolded according to UML standards but in this case, it clearly is not. This is just a line joining the alt paths together.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]