Open zoristaken opened 2 weeks ago
Issue #806 will help implementing the Matrix Restabilizer and Apparatus of Khaz'goroth trinkets
Some additional comments, the trinkets that have not been implemented yet are either healing trinkets that I don't know how to go about, or have some sort of mechanic that I didnt investigate if the core allows it right now (example: stacking mana cost reduction during aura on Jaws of Defeat).
I also have some TODO comments that need addressing. Need to double check that I didn't mess up any numbers but otherwise would like a review of what's already implemented
Tank trinkets should be pretty straight forward to implement, at least by someone with a bit of absorb-knowledge (e.g. @rosenrusinov 😅).
Jaws of Defeat should be possible to implement with a dynamic spell mod using SpellMod_PowerCost_Flat right? Just reset the FloatValue on gain and add 110 to the current each stack?
Tank trinkets should be pretty straight forward to implement, at least by someone with a bit of absorb-knowledge (e.g. @rosenrusinov 😅).
Jaws of Defeat should be possible to implement with a dynamic spell mod using SpellMod_PowerCost_Flat right? Just reset the FloatValue on gain and add 110 to the current each stack?
I might leave tank/healing trinkets not implemented by now and we can just focus and making sure the ones I have are correct. If that's the case I will just open an issue to track what's left to implement
1. Raid items
[x] Vessel of Acceleration
[x] Vessel of Acceleration Heroic
[x] Matrix Restabilizer
[x] Matrix Restabilizer Heroic
[x] Variable Pulse Lightning Capacitor
[x] Variable Pulse Lightning Capacitor Heroic
[ ] Jaws of Defeat
[ ] Jaws of Defeat Heroic
[x] The Hungerer
[x] The Hungerer Heroic
[ ] Spidersilk Spindle
[ ] Spidersilk Spindle Heroic
[x] Necromatic Focus
[x] Necromatic Focus Heroic
[ ] Eye of Blazing Power
[ ] Eye of Blazing Power Heroic
[x] Apparatus of Khaz'goroth
[x] Apparatus of Khaz'goroth Heroic
[ ] Scales of Life
[ ] Scales of Life Heroic
2. Avengers of Hyjal and Quest Rewards
There seems to be heroic versions of the avengers of hyjal items in the database, but those were not available back in the day, just like the heroic trash loot from tier 11 raids.
[ ] Stay of Execution
[x] Rune of Zeth
[x] Fiery Quintessence
[x] Ancient Petrified Seed
[x] Essence of the Eternal Flame
[x] Dwyer's Caber
[x] Moonwell Chalice
[x] Moonwell Phial
[x] Ricket's Magnetic Fireball
Brewfest
Do we even bother implementing the tank's brewmaiden on use? bubblier and bitterer
[x] Brawler's Trophy
[x] Coren's Chilled Chromium Coaster
[x] Mithril Stopwatch
[x] Petrified Pickled Egg
TBD
The legendary staff will require more thought than any of the other items to implement. There needs to be a discussion if we even bother implementing it following simc and old data for now, or we wait for more information.