wowsims / cata

World of Warcraft Cataclysm Classic simulations.
https://wowsims.github.io/cata/
MIT License
25 stars 46 forks source link

[SHADOW] Add shadow priest softcap breakpoints #808

Closed 1337LutZ closed 2 months ago

1337LutZ commented 3 months ago

Calculated and added breakpoints together with InDebt

Based off this detailed scaling graph and picked some minor peaks to allow for in between breakpoints image

1337LutZ commented 3 months ago

Put this on pending to fine tune with Lenlo 👍

1337LutZ commented 3 months ago

@InDebt Ready to be reviewed. Refined additional semi-breakpoints to smoothen the EP scaling a bit. During that found some additional points.

InDebt commented 3 months ago

Those breakpoints seem reasonable. I am wondering about two points though:

Checked the 5049 (0.43 EP) breakpoint and added 50 haste which were (60 DPS w/o shadowform) and added 50 mastery which were 25 DPS - so haste is still twice as good as mastery here. In our bis gear as those breakpoints should be applicable to our gear we actually wear

1337LutZ commented 3 months ago

I did it Naked because I talked to Linelo and that's how he did all his research. So the Haste breakpoints were done like this:

Then for all the EP values I actually used:

Then increment towards each of the values.

I'll check your findings after dinner

1337LutZ commented 2 months ago

Closing this as we will use default EPs as a default since prioritizing haste is the best no-brain option. Added dropdown for breakpoint selection is this PR to allow for easier manual fine tuning: https://github.com/wowsims/cata/pull/825