search

wowsims / cata

World of Warcraft Cataclysm Classic simulations.
https://wowsims.github.io/cata/
MIT License
31 stars 47 forks source link

Web tool : simulation never goes through #881

Open Critxtth opened 3 months ago

Critxtth commented 3 months ago

Describe the bug

First of all thanks a lot for your work, wowsims is a great app 💕 I've been using your web tool since the begginning of WOTLK and never came accross any issue. Very recently, I've been trying to sim my chars, but the simulation never ends. It stops in the middle of the iterations, and doesn't show real DPS. I havent touched any settings, and it happens on every class/spec that I try to sim. I tried different web browsers, private navigation, doesn't fix the problem. The video of the issue is available here : https://medal.tv/games/pc-simulator/clips/ilVYHgJTpcsEu1APL/d1337VaNi1pD?invite=cr-MSw4eFAsMzk5NTIzNiw

To Reproduce Steps to reproduce the behavior:

  1. Go to web tool
  2. Select any spec (I tested fire mage, combat rogue, shadow priest)
  3. Launch sim
  4. See error

Expected behavior Finish the job and display real DPS

Sim Links and Screenshots If applicable, add links to your sim settings or screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

FelixPflaum commented 3 months ago

Does the browser console show errors? Does it still happen if you set the worker count to 0 (the cog button top right, set "Use Multiple CPU Cores" to off)?

Critxtth commented 3 months ago

Here is he output on the console :

image

Uncaught (in promise) TypeError: WebAssembly compilation aborted: Network error: Response body loading was aborted Promise.then (anonymous) @ sim_worker.js:617

It seems like it fixes the problem indeed. Mine was set to 4, I turned it off and it worked again. It seems like it works for value = Off, or 2, but doesn't work for the values above.

But thatll do it for me, thanks for your fast answer ! You can close the issue if you want. 👍 💕

FelixPflaum commented 3 months ago

Not sure if that is a bug with the site or with your network/browser. But in any case an error like that should be handled and not cause the sim to just get stuck for the user. Therefore this should stay open until that is resolved.

dexxiez commented 3 months ago

885 related?

rosenrusinov commented 3 months ago

885 related?

Most likely yes

FelixPflaum commented 3 months ago

885 related?

Most likely yes

No, that's an actual sim error. Here the lib.wasm isn't loaded so the worker doesn't even do anything, and there's no error handling for that atm. And because of that the concurrency code sends partial work to dysfunctional workers and never gets an error back, so it just gets stuck visually waiting for progress.

Caldorwow commented 3 months ago

Having the same issue after downloading the Local SIM. Even after I deleted it it is still doing it.

FelixPflaum commented 3 months ago

@Caldorwow It just gets stuck without showing any error? Could you provide an export link of your settings?