wowsims / cata

World of Warcraft Cataclysm Classic simulations.
https://wowsims.github.io/cata/
MIT License
24 stars 46 forks source link

Missing firelands patch procs implementations #902

Open zoristaken opened 1 month ago

zoristaken commented 1 month ago

1. Raid items

2. Avengers of Hyjal and Quest Rewards

There seems to be heroic versions of the avengers of hyjal items in the database, but those were not available back in the day, just like the heroic trash loot from tier 11 raids.

Brewfest

Do we even bother implementing the tank's brewmaiden on use? bubblier and bitterer

TBD

The legendary staff will require more thought than any of the other items to implement. There needs to be a discussion if we even bother implementing it following simc and old data for now, or we wait for more information.

InDebt commented 1 month ago

Regarding Dragonwrath. I think it would be a good Idea to open a research ticket where we can collect all info on the staff and people can report issues so it's in one place. After that we should implement a baseline implementation. People will inevitably want to sim the staff and bug us in discord, or will be forced to use other means to sim the staff. I.e, loading the old simc versions and trying to sim it there, potentially drawing the wrong conclusions.

My idea would be to either have a general info box, or only when we select / equip the staff, that the staff's exact interactions are to be verified and should not be trusted deeply.

@1337LutZ What do you think about that and do you have a good Idea how to design a proper UX around that, potentially without any big dev work involved, can we do something like this already?

1337LutZ commented 1 month ago

@InDebt it should be fairly easy to add a persistent warning toast using the equip emitter. This would be non dismissable and will be shown in the sidebar 👍 informing the user about the usage of the staff, and also a link to the issue/thread where they can add findings.

Bisonpasfute commented 3 weeks ago

Regarding Ancient Petrified Seed and probably the others 1 minute CD Trinkets from the Avengers of Hyjal, Would it be possible to add them to the Cooldowns so we could use them like the others on use trinkets ? Thank you!

zoristaken commented 3 weeks ago

Regarding Ancient Petrified Seed and probably the others 1 minute CD Trinkets from the Avengers of Hyjal, Would it be possible to add them to the Cooldowns so we could use them like the others on use trinkets ? Thank you!

This should already be the case, the heroic versions were not available in the game but are still in the database, so if that's the one you are trying to use it won't work because I did not implement unavailable versions

Bisonpasfute commented 3 weeks ago

Regarding Ancient Petrified Seed and probably the others 1 minute CD Trinkets from the Avengers of Hyjal, Would it be possible to add them to the Cooldowns so we could use them like the others on use trinkets ? Thank you!

This should already be the case, the heroic versions were not available in the game but are still in the database, so if that's the one you are trying to use it won't work because I did not implement unavailable versions

Indeed, I later figured that those version will be removed at some point. I just check the 378 version and it's working as it should normally, sorry !