DPS Histogram and Errors with Death in Encounter

wowsims / sod

World of Warcraft Classic Season of Discovery simulations.

https://wowsims.github.io/sod/

MIT License

15 stars 49 forks source link

DPS Histogram and Errors with Death in Encounter #1089

Open sanguinerarogue opened 1 month ago

sanguinerarogue commented 1 month ago

The DPS histogram, iteration dps values and possibly average DPS values seem to have some errors when a death is incurred in an enounter.

Rogue Tank sim during Vael (40s): Rogue Tank sim during Vael (39s):

Mage Balefire Bolt at 5 stacks: Mage Balefire Bolt at 4 stacks (11s sim):

In addition the mage balefire code needs to be updated to 5 stacks for the death and spirit coefficient logic, I will submit a separate bug for that.

1337LutZ commented 1 month ago

@sanguinerarogue I'm not sure this is a bug. The code does the following:

min = avg - stdDev
max = avg + stdDev

If you die a lot of the iterations the range makes sense and seems to be accurate.

1337LutZ commented 1 month ago

As discussed on Discord, this seems to be caused by .CleanUp in the Balefire / Vael encounter. Things are not being cleaned up and are being passed along the next iteration.