search

wowsims / sod

World of Warcraft Classic Season of Discovery simulations.
https://wowsims.github.io/sod/
MIT License
13 stars 32 forks source link

Blood Fury AP calculation is not accurate due to Strength-AP conversion ratio #863

Closed neustart closed 1 day ago

neustart commented 4 days ago

Describe the bug Blood Fury AP calculation is not accurate due to strength conversion ratio. Hardcoded as AP=STR*2, while true for most melee classes is not the case for Rogue and Hunter, their conversion rate is AP=STR.

To Reproduce Steps to reproduce the behavior:

  1. Go to SoD rogue sim
  2. Sim as orc vs any other race
  3. Check stat weights, Strength is overvalued due to incorrect calculation

Expected behavior Blood Fury AP contribution from STR should be "STR" and not "2*STR" for Rogues.

Additional context https://vanilla-wow-archive.fandom.com/wiki/Attributes#Strength

sanguinerarogue commented 2 days ago

Going to reopen this so I can test in game tomorrow and confirm. I believe rogue calculation should be: (Base AP + Agility from Gear + Str from Gear) * AP. This is how it was implemented in the previous rogue dps sheets.

sanguinerarogue commented 2 days ago

image

confirmed scales with agility for rogues

sanguinerarogue commented 1 day ago

Fixed in recent commit