search

wowsims / sod

World of Warcraft Classic Season of Discovery simulations.
https://wowsims.github.io/sod/
MIT License
13 stars 44 forks source link

Port item sets by ID from Cata then update crafted item set bonuses #940

Closed Accomp closed 2 months ago

Accomp commented 2 months ago

Describe the bug When equipping the 2-piece of Devilcore, the +10 fire resistance bonus is not being added to the stats listing in bottom left sheet.

To Reproduce Steps to reproduce the behavior:

  1. Add both Devilcore pieces.
  2. View fire resistance value in stat module.
  3. Remove one devilcore piece to break set.
  4. Observe the +10 set bonus was not being applied.

Expected behavior +10 fire resist stat bonus to be presented in state panel properly.

Sim Links and Screenshots Sim Link (Rogue)

Desktop (please complete the following information):

kayla-glick commented 2 months ago

For whatever dev takes a look at this, because a lot of the updated item sets have the same name we need to port setting up sets by set ID from the Cata site in order to properly support them. We then need to do a full pass at all of the crafted sets to make sure both versions are included

kayla-glick commented 2 months ago

Oops didn't mean to close

kayla-glick commented 2 months ago

Pushed up an update that adds item set IDs and updates the phase 4 crafted set bonuses