Suggest Gems - Meta gem activation not prioritized

[Kood650]

Describe the bug Suggest gems is not prioritizing having the meta gem activated. ex: in a set with only yellow and red gem slots nightmare tear will not be selected. If a set has a blue gem slot nightmare tear is selected.

To Reproduce Steps to reproduce the behavior:

1. Go to 'set link'
2. Click on 'Suggest Gems'
3. Check that meta gem is not activated (no blue gems)
4. Replace any gem with nightmare tear resulting in a significant dmg increase (+- 300 dps).

Expected behavior Meta gem provides a big dmg increase so it should be prioritized having it activated. Some math is necessary to check which slot color slot should be used but feelscraft says it should be a yellow one (hit and exp caps in some sets might make this not true). Either way, using a red slot or yellow slot should increase overall dmg (citation needed).

Desktop (please complete the following information):

• OS: WINDOWS
• Browser CHROME
• Version: cba

Additional context Related to this issue. - https://github.com/wowsims/wotlk/issues/3257

[BorniPL]

The functionality is not ready for Phase 4 yet - that's for sure.

Do you know what hit/expertise/arpen/crit cap are we going for in P4? I don't.

[Kood650]

This doesn't seem to be related to hit/exp/arp caps of phases. If you look at this set with only phase 3 gear it still does not take into account meta gem activation, set link, if you put a nightmare tear in any gem socket you will see a dmg increase. Anyway, there now seems to be a warning about the meta gem being disabled (maybe there was one already and I was blind) so thanks!

[BorniPL]

I didn't read the code, but I can safely assume that it tries to fit it in the blue socket and in this gearset you lack one (it doesn't consider prismatic socket as a blue one).

[jarveson]

this looks fixed at some point, linked set will suggest one with nightmare tear