search

wowsims / wotlk

World of Warcraft Wrath of the Lich King Classic simulations.
https://wowsims.github.io/wotlk/
MIT License
147 stars 139 forks source link

updating default Retribution APL #4184

Open Surveillant0 opened 9 months ago

Surveillant0 commented 9 months ago

DS > CS rotation (aka High-roll) as the new default includes a condition to prio CS higher if Libram duration is low for people without the Libram, the rotation will end up doing CS > DS instead, unless that action is disabled however CS > DS is still a perfectly fine and optimal rotation anyway also includes cancelaura action for Shadowmourne but this is disabled by default, as it is currently bugged in-game

Surveillant0 commented 9 months ago

not sure if I need to fix a bug somewhere or if I need to update expected results, first time updating an APL

kayla-glick commented 9 months ago

Hey @Surveillant0! Looks like the update is making the tests fail (which isn't surprising). Since the numbers went up I assume that's totally fine, so you can run make update-tests then commit those changes and it should be good!

Surveillant0 commented 8 months ago

Hey @Surveillant0! Looks like the update is making the tests fail (which isn't surprising). Since the numbers went up I assume that's totally fine, so you can run make update-tests then commit those changes and it should be good!

thanks I will do this as soon as I am able to! appreciate the reply