search

wowsinfo / WoWs-Info-Seven

WoWs Info is an assistant for World of Warships
https://wows-info.herokuapp.com
MIT License
67 stars 16 forks source link

Localisation & Language Repo #74

Closed HenryQuan closed 2 years ago

HenryQuan commented 2 years ago

In the rewrite, we have old localised strings from React Native and the game. We can merge these two into one file. Localised strings from the game will have a variable instead of passing a manual string, like LangRepo.instance.filterShipByType instead of LangRepo.instance.stringOf('filter').

Currently, we don't have this repo yet, and we get the string from GameRepository. This shouldn't be the way how we achieve it. All localisation related functions should be removed to our new repo. Localisation can be the name or LanguageRepository.

HenryQuan commented 2 years ago

This is implemented in 8c9236d6 as Localisation.