search

woxtu / rust-opencv

Wrapper for OpenCV (WIP, not compilable now)
13 stars 5 forks source link

cascade classifier(CvHaar..) and objdetect module #2

Closed jonysy closed 9 years ago

jonysy commented 9 years ago

Added CascadeClassifier (CvHaarClassifierCascade) and the objdetect module (just the cvHaarDetectObjects method). I'm pretty certain the cvHaarDetectObjects method is from the older opencv version and is deprecated but I couldn't find any newer C methods for this..

Wasn't sure what to name the safer version of CvSeq (or should I have just implemented an Iterator for CvSeq?) so I just named it Seq (src/core::Seq) but feel free to merge and change it to whatever fits.

woxtu commented 9 years ago

Thank you for your PR. But I'm afraid to say I can't receive this. Some reasons will be described below.

And I have a favor to ask of you. When you send PR, please squash some commits into single commit, and commit message starts with base form of the verb + a capital letter.

woxtu commented 9 years ago

Hmm... Simply speaking, please copy my coding style.

jonysy commented 9 years ago

Sorry about the brevity of the commit message. A few of the mistakes listed, such as that, should have been obvious.

Please consider adding something like a contributor's guide (see this -- it doesn't have to be a separate file but a section in the README, with a list of your style preferences, may be very helpful to other developers who would like to contribute).

Per your request, I will abide by your style rules and have pushed the requested changes described above :)

woxtu commented 9 years ago

I'll think about it.

By the way, please reply to #1.