add attributes to <li> pagination elements

woylie / flop_phoenix

Components for pagination, sortable tables and filter forms using Phoenix, Ecto and Flop

MIT License

354 stars 37 forks source link

add attributes to <li> pagination elements #307

Closed tmbb closed 2 months ago

tmbb commented 6 months ago

This change is essential to be able to use Bootstrap5 CSS with Flop.Phoenix (bootstrap is very particular with how elements must nest inside each other. Probably needs some tests before merging.

woylie commented 6 months ago

This change is essential to be able to use Bootstrap5 CSS with Flop.Phoenix (bootstrap is very particular with how elements must nest inside each other. Probably needs some tests before merging.

Haven't they heard about CSS selectors? 😄

I made two suggestions. Could you also add a test?

woylie commented 2 months ago

Closed in favor of #337