Support attributes on list items in pagination.

woylie / flop_phoenix

Components for pagination, sortable tables and filter forms using Phoenix, Ecto and Flop

MIT License

354 stars 37 forks source link

Support attributes on list items in pagination. #337

Closed tschmidleithner closed 2 months ago

tschmidleithner commented 2 months ago

Unfortunately PR #307 has never been merged until today. However, I also need the functionality to set a specific CSS class for list items in order to support Bootstrap 5 pagination.

This PR incorporates code review suggestions from #307. Furthermore, the new pagination option pagination_list_item_attrs is also covered by a test.

coveralls commented 2 months ago

coverage: 99.804%. remained the same when pulling be28290fbad49af34b2750b63003f1fa076bf33d on tschmidleithner:pagination-list-item-attributes into b1be78bd948c964a6dd69e98cbd8914d4c43af32 on woylie:main.

woylie commented 2 months ago

Thank you for finishing this up!