Fix pagination_list_item_attrs missing from right ellipsis list item

woylie / flop_phoenix

Components for pagination, sortable tables and filter forms using Phoenix, Ecto and Flop

MIT License

354 stars 37 forks source link

Fix pagination_list_item_attrs missing from right ellipsis list item #355

Closed tudborg closed 2 weeks ago

tudborg commented 2 weeks ago

This commit adds the pagination_list_item_attrs option to the right ellipsis list item. The test to cover this only verified that the first list child had the assigned options. I've changed it to verify all list items, and added opts to trigger ellipsis rendering.

This was missing from the #337 PR that introduced pagination_list_item_attrs.

coveralls commented 2 weeks ago

coverage: 98.608%. remained the same when pulling f4500bf26c0231f8eca32358221549ccb16c07a5 on tudborg:fix-missing-pagination-list-item-attributes-on-ellipsis into e2b7738cbbd6b1a64ded72b3625dd8152cf5dba9 on woylie:main.

woylie commented 2 weeks ago

Nice, thank you!