Open sodapopcan opened 1 week ago
Hi @sodapopcan,
I don't think I want to add another option to the component for this. It might make more sense to just move the symbol inside the link by default. Might require updating the styles in some applications, though.
The fewer options the better, absolutely. The fact that this could (and probably will) mess with some peoples' styles is why I proposed it as an option. Perhaps it could be temporary with a deprecation across minor versions? That still adds a documentation burden, of course.
If this is a no-go I can actually easily hack around it with some JS.
I don't like adding temporary option for this. I think we can probably make the change with the next minor version, as long as we add a clear note in the changelog.
Yep, I'm just full of bad ideas (temporary option) 😅
Ok, thank you so much, this is a big help!
Hiya @woylie,
Would you be open to including an option to allow the sort symbol to be clickable as well. Perhaps the whole header even? Our design system shows a symbol when a field is sortable but unsorted and it really makes people want to click it. I'm happy to do the work.
Thanks for the awesome lib!
Andrew