Closed notoddity closed 1 year ago
This is way better than what I do to test which is comment and uncomment lines lmao.
Yea .venv
in .gitignore
is fine.
Lots of other stuff is hardcoded tho, in the plugins themselves, I don't know how I feel about moving them to a constants.py file cuz then the plugins aren't really self contained anymore.
🤔 Good point, I don't quite know how we could make those not hardcoded without making the plugins not self contained. Maybe a find_spec for the constants file, but fail over to default? Trying to get it running locally so I can help with some of the issues you have posted.
The main thing is that stuff like emoji are hardcoded which are hard to just pull from the environment because there could be dozens of emoji. similarly with roles.
Maybe a constants file could work, I think that's how some of the other bots do it.
Wasn't able to test previous change due to the guild id being hard coded. Would be nice to be able to join it to a test server with a test bot. BUT left all the default hard-coded id's for guild, admin role so there is no changes to how you start the bot on your end. Oh and .venv to the .gitignore didn't understand what ".direnv" was until I pushed this. Sorry about that, can remove it if you want but just left it in-case there are any other ".venv" enjoyers who decide to make a pr.