search

wp-bootstrap / wp-bootstrap-navwalker

A custom WordPress nav walker class to fully implement the Twitter Bootstrap 4.0+ navigation style (v3-branch available for Bootstrap 3) in a custom theme using the WordPress built in menu manager.
https://wp-bootstrap.github.io/wp-bootstrap-navwalker/
GNU General Public License v3.0
3.37k stars 1.94k forks source link

Review 5.4 Changes #465

Open bhubbard opened 4 years ago

bhubbard commented 4 years ago

Review how 5.4 changes can be used to improve our navwalker.

WordPress 5.4 Introduces new hooks to add custom fields to menu items

IanDelMar commented 3 years ago

I have looked into this and while it would be useful in terms how easily one can configure menu items, when using custom fields you add database calls reducing the performance of the nav walker (without caching). If the first outweighs the latter WP Bootstrap Navwalker should definitely use custom fields, if not one should forget about the custom fields. Custom fields also add to lower maintainability (set up and save custom fields, and so on). My preference: no custom fields.