wp-bootstrap / wp-bootstrap-navwalker

A custom WordPress nav walker class to fully implement the Twitter Bootstrap 4.0+ navigation style (v3-branch available for Bootstrap 3) in a custom theme using the WordPress built in menu manager.
https://wp-bootstrap.github.io/wp-bootstrap-navwalker/
GNU General Public License v3.0
3.37k stars 1.94k forks source link

Drop default value for title attribute #468

Closed IanDelMar closed 4 years ago

IanDelMar commented 4 years ago

Setting the title attribute to the item title if empty a) just duplicates information which is already there, b) does not what the title attribute is intended to do (giving advisory information related to the element it belongs to), c) may cause accessibility issues (see https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#Accessibility_concerns), an thus should be dropped completely instead of providing the option to turn it off as proposed in #448.

I guess, it is also what people expect the walker to do when there is no user input.

Fixes #

Changes proposed in this Pull Request:

*

Testing instructions:

*

Proposed changelog entry for your changes: