search

wp-bootstrap / wp-bootstrap-navwalker

A custom WordPress nav walker class to fully implement the Twitter Bootstrap 4.0+ navigation style (v3-branch available for Bootstrap 3) in a custom theme using the WordPress built in menu manager.
https://wp-bootstrap.github.io/wp-bootstrap-navwalker/
GNU General Public License v3.0
3.37k stars 1.94k forks source link

Remove role="menu" #480

Closed IanDelMar closed 4 years ago

IanDelMar commented 4 years ago

Changes proposed in this Pull Request:

Removes role="menu" from <ul> tag in start_lvl(). Bootstrap follows the disclosure design pattern which does not use any menu related aria roles. See https://github.com/wp-bootstrap/wp-bootstrap-navwalker/pull/456#issuecomment-661602093 for more details.

Closes PR #456 and #475.